Skip to content

fix(tests): re-enable skipped tests from Rust migration (#39) - #54

Merged
zackees merged 1 commit into
mainfrom
fix/reenable-skipped-tests
Apr 12, 2026
Merged

zackees merged 1 commit into
mainfrom
fix/reenable-skipped-tests

Conversation

@zackees

@zackees zackees commented Apr 12, 2026

Copy link
Copy Markdown
Member

Summary

  • Deleted MicrophoneHttpsIntegrationTest — HTTPS tests no longer applicable after dropping Flask/HTTPS in PR feat: replace Flask with Rust HTTP server (#45) #48
  • Kept MicrophoneDemoValidationTest (validates micdemo.html content)
  • Cleaned #39 reference from test_cli.py skip marker
  • Added new test_http_server.py — smoke test that spawns the Rust CLI with --serve-dir, fetches index.html, verifies 200 response
  • Fixed pre-existing pyright/black issues in playwright_browser.py and resize_tracking.py

New test: HttpServerSmokeTest

Replaces the deleted HTTPS integration tests. Locates the Rust CLI binary (distinguishes from maturin wrappers by size >10MB and help output), starts it with --serve-dir, parses the auto-assigned port, makes an HTTP request, and verifies a 200 response.

Test plan

  • bash lint — 0 pyright errors
  • bash test — 120 tests pass (119 existing + 1 new)
  • CI passes

Closes #39

- Delete MicrophoneHttpsIntegrationTest class (HTTPS dropped in PR #48)
- Keep MicrophoneDemoValidationTest for micdemo.html content validation
- Remove #39 tracking references from skip markers
- Add test_http_server.py: HTTP smoke test using the Rust CLI binary
- Fix pre-existing pyright errors (playwright import suppressions)
- Fix pre-existing black formatting in playwright module
@zackees
zackees merged commit c06b85f into main Apr 12, 2026
25 checks passed
@zackees
zackees deleted the fix/reenable-skipped-tests branch April 12, 2026 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix: re-enable skipped tests from Rust migration

1 participant